-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy and Build Site Job failing #4
Comments
It looks like I forgot to configure your repository for automatic PRs to update the workflows. Sorry for the oversight. I have fixed that now so you can expect to start receiving pull requests from the @carpentries-bot account occasionally to update your GitHub Actions workflows. (These can be safely merged when they appear.) For now, you can manually update the workflow files by following the instructions here: https://carpentries.github.io/sandpaper-docs/update.html#deployment I suspect that updating the workflows will solve the problem, and it is certainly a good place to start. |
Hi @tobyhodges, thanks very much for your assistance with this. I have updated the workflows as you advised, and merged the pull requests I received. Unfortunately this hasn't resolved this issue and I am still unable to build and deploy my site. Looking at the logs, the specific issue is with the setup package cache job. the logs for the most recently failed job is here - https://github.com/carpentries-incubator/rna-seq-data-for-ml/actions/runs/6470423763/job/17566604303#step:25:665 It appears that the error is caused by a package version conflict. Specifically, the package vctrs is a dependancy of multiple packages installed and the version updated to a previous version somewhere in the installation process. The specific error message is: The following package(s) have unsatisfied dependencies:
line 552 shows that this package has had the version changed during the package installation job.
Is there a way I can force the final package version in my code that will be respected when the job runs? Are you aware of any other solution to this? Sorry to bug you again with this issue. Thanks, |
Thanks for digging into the build logs and identifying the problem, @parkyed. Please try the solution described at the end of the opening post of this issue carpentries/workbench#40 (comment):
Post back here to let me know if that helped or if we need to keep digging. |
Hi @tobyhodges, thanks again for the quick help here. Running job 03, Update Cache workflow also failed. The error relates to installing packages that are not available on CRAN. These packages are however available on Bioconductor. The error message is as follows:
It appears from the logs that when running the update cache from the job 03: Maintain: Update Cache workflow, that where packages are not available on CRAN, the job doesn't then look elsewhere to find these packages. However, when running job 01: Build and Maintain site, within the Setup Package Cache part of the job, when packages are not found on CRAN, the job appears to then look for them on bioconductor. See logs below and here -https://github.com/carpentries-incubator/rna-seq-data-for-ml/actions/runs/6479705635/job/17593771555#step:25:665 line 387 onwards. In this case these packages are successfully downloaded, however the job overall fails due to the race condition around package versions. Is there an inconsistency between how job 01 and job 03 behave in relation to packages not found on CRAN that may be causing the race condition around package dependencies? Output from lines 387 onwards of most recent attempt to build site:
|
Pinging @froggleston @klbarnes20 @ErinBecker @zkamvar I have reached the limit of my Workbench knowledge. Please could you explore what might need to be done here? To summarise the issue as I understand it:
|
Could the renv.lock file in the PR be edited to force certain package versions? In my limited knowledge, step 01 has an explicit cache update task, but 03 doesn't? I don't think updating this is correct though as this would affect every lesson built. In my experience in python with dependency issues, locking versions is sufficient until subsequent packages are updated in repositories? |
@froggleston @klbarnes20 and I tested the fix proposed by @tobyhodges above by checking out PR #6. This helped some - it updated all of the packages except for Rcpp. There appears to still be some package dependency issue with Rcpp. Old error message:
New error message after checking out PR #6
This is strange because PR #6 is updating Rcpp to version 1.0.11, which is in fact on CRAN. |
Interestingly, I decided to delete the renv folder from my local update/packages checked out branch and the build succeeds... |
I had some time to speak with @froggleston about this and from his summary, the solution is indeed to manually (as in on a local machine) remove the renv/ folder and re-run The reason we find ourselves in this situation is because of an unfortunate race condition with package dependencies. This is in part because the original lockfile was never updated since the inception of this package. Ideally, the lockfile should be updated once every month. Luckily, the solution that @froggleston found is the correct solution because removing the |
@tobyhodges, @froggleston @klbarnes20 @ErinBecker @zkamvar - thanks very much for your comments and help with this. I merged in #6 and this seemed to solve the issue. For now, I'll hold off deleting my local renv folder - I'm not exactly sure which one to delete. Hopefully this is now solved. Thanks very much again all! |
In any workbench lesson, if there is a problem with the renv cache, you can use the following commands to reset it inside the lesson: rm -r renv/
git restore renv/ |
Hi @parkyed - was this resolved for you? If so I can close this issue. If not, please let us know if there's anything else we can help with! |
Hi @froggleston, thanks for following up on this. Yes, this has been resolved, and i'm happy for the issue to be closed. I'll close it with this comment. Thanks! |
Hi @tobyhodges , I wonder if you are able to assist me here. My Deploy and Build Site Job is failing on this project. I have been unable to figure out why it no longer works. The course is now complete, and I am hoping to begin a pilot in the next month or so.
Thanks for any advice you are able to provide,
Ed
The text was updated successfully, but these errors were encountered: