Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No permission dialog on iOS11 when permission is denied #16

Open
daveluong opened this issue Oct 3, 2017 · 5 comments
Open

No permission dialog on iOS11 when permission is denied #16

daveluong opened this issue Oct 3, 2017 · 5 comments

Comments

@daveluong
Copy link
Contributor

daveluong commented Oct 3, 2017

Steps to reproduce

Go to Device Settings
Select Pickle Example
Select Photos, Select "Never"
Then, launch Pickle Example
Select any
Here, you will see the old image picker format, even though you do not give Picker Example access to Photos.app
Then, select a photo
You will see a blank page that is unresponsive, requiring you to kill app

Actual outcome
unresponsive page

Expected outcome
If access to Photos is disabled, client should show a page that informs you that access is required before proceeding to Sell Form. See attached image for what the prompt is on production for iOS10 and below


Upon initial investigation, it appears to be bug in UIImagePicker in iOS11.

@bcylin
Copy link
Collaborator

bcylin commented Oct 3, 2017

Is there any plan to work around this issue or to replace the permission denied screen?

@daveluong
Copy link
Contributor Author

No concrete plan at the moment. I think we will continue observing, if it escalates we might need to handle the denied state using custom view instead pf relying on UIImagePickerController

@daveluong
Copy link
Contributor Author

@bcylin What is the reason that we're showing UIImagePickerController when the permission is case .denied, .restricted: ?

@daveluong
Copy link
Contributor Author

Proposed fix:

Solution 1:
Add 1 more function to ImagePickerDelegate that call delegate when permission status is .denied or .restricted and let delegate handle it on their own

Solution 2:
Create a custom view to show permission error within Pickle instead of relying on UIImagePickerViewController

@bcylin
Copy link
Collaborator

bcylin commented Oct 5, 2017

It was because of the product design. It shows the system message when the permission is not granted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants