Change badges in README (shown at the top and in the example) to use markdown syntax #1670
Open
3 tasks done
Labels
discussion
Discussions about the proposal of an emoji.
Discussion
The badges in the current README have an underline between them as they use
a
tags and ap
with center to center them.I'm unsure to whether this is fixable in other ways, but I found that replacing them with markdown tags and a
div
with center makes the underline disappear, as noted in other repository READMEs like Astro or Bacon.Example
Here is a picture of the issue:
You can note an underline between the links. This corresponds to the link on the left. I'm not sure why my Google Chrome doesn't render the emojis...
Here is what changing to inline markdown links looks like:
The underline is gone.
Technical Details
The exact changes are as follows:
This change will not affect the accessibility of the HTML generated as the Alt properties are added through the markdown format. One possible issue is that the emoji in the second link are converted to percent-encoded.
There is also the slight concern that the new markdown will have required newlines between the HTML and markdown. I'm not sure if this is a good thing or a bad thing, but it's definitely a thing.
If these changes seem good, I have a fork of this repository with the updated top badges and example.
Additional Notes
I'm unsure if I should follow the local testing guideline if I make a commit just to fix the README as there would be no code changes. Would this be a 💄, or a 📝? I'm not sure.
Validations
The text was updated successfully, but these errors were encountered: