Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Prometheus exporter to ROCK #185

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Move Prometheus exporter to ROCK #185

merged 1 commit into from
Jan 18, 2024

Conversation

gtrkiller
Copy link
Contributor

Applicable spec:

Overview

Install the Apache Prometheus exporter into Wordpress' ROCK

Rationale

This change simplifies the architecture of the charm by reducing the amount of resources and containers it needs

Juju Events Changes

N/A

Module Changes

N/A

Library Changes

N/A

Checklist

@gtrkiller gtrkiller added the enhancement New feature or request label Jan 18, 2024
@gtrkiller gtrkiller requested a review from a team as a code owner January 18, 2024 13:08
@github-actions GitHub Actions
Copy link
Contributor

Test coverage for e7239ab

Name                Stmts   Miss Branch BrPart  Cover   Missing
---------------------------------------------------------------
src/charm.py          540     35    182     32    91%   186-189, 353-354, 413->417, 566, 597, 603, 620-624, 654, 689-690, 747, 756, 860->865, 864, 866, 871-872, 932, 950, 957, 1047, 1056, 1068, 1089, 1098, 1117, 1121, 1150, 1203, 1335, 1357, 1364->1366, 1409->exit, 1421, 1437, 1474
src/cos.py             15      0      0      0   100%
src/exceptions.py      17      1      2      1    89%   41
src/state.py           34      0      4      0   100%
src/types_.py          16      0      0      0   100%
---------------------------------------------------------------
TOTAL                 622     36    188     33    91%

Static code analysis report

Run started:2024-01-18 13:11:08.699498

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 4424
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@gtrkiller gtrkiller changed the title Move Pormetheus exporter to ROCK Move Prometheus exporter to ROCK Jan 18, 2024
@gtrkiller gtrkiller merged commit 7fe59b5 into main Jan 18, 2024
35 checks passed
@gtrkiller gtrkiller deleted the fix_exporter branch January 18, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merkata merkata merkata approved these changes

@arturo-seijas arturo-seijas arturo-seijas approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gtrkiller @merkata @arturo-seijas