Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useEffect React Hook warning when building the NMS #617

Open
patriciareinoso opened this issue Jun 19, 2024 · 0 comments
Open

useEffect React Hook warning when building the NMS #617

patriciareinoso opened this issue Jun 19, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@patriciareinoso
Copy link
Contributor

Describe the bug

When we build the NMS, there is a warning:

./components/SubscriberModal.tsx
160:6  Warning: React Hook useEffect has missing dependencies: 'oldDeviceGroupName', 'oldNetworkSliceName', 'selectedSlice', 'setDeviceGroup', and 'subscriber'. Either include them or remove the dependency array.  react-hooks/exhaustive-deps

This does not affect the build but it can cause infinite re rendering of the application when it is running.

To Reproduce

  1. npm run install
  2. npm run build

Expected behavior

When we build the NMS this warning should not exist

Additional context

Not an urgent issue

@patriciareinoso patriciareinoso added bug Something isn't working good first issue Good for newcomers labels Jun 19, 2024
@patriciareinoso patriciareinoso changed the title Missing dependencies on a React Hook warning when building the NMS Missing dependencies on a useEffect React Hook warning when building the NMS Jun 19, 2024
@patriciareinoso patriciareinoso changed the title Missing dependencies on a useEffect React Hook warning when building the NMS useEffect React Hook warning when building the NMS Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant