Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a jsonschema for charmcraft.yaml in jsonstore #687

Open
facundobatista opened this issue Feb 24, 2022 · 4 comments
Open

Add a jsonschema for charmcraft.yaml in jsonstore #687

facundobatista opened this issue Feb 24, 2022 · 4 comments
Labels
Enhancement New feature or request triaged
Milestone

Comments

@facundobatista
Copy link
Contributor

The idea is that editors could retrieve automatically the schema from the json schema store and validate that charmcraft.yaml makes sense.

@sed-i
Copy link
Contributor

sed-i commented Sep 16, 2023

@lengau, with the unified charmcraft.yaml this would make a lot of sense!
This would also obviate juju/charm#370.

@lengau
Copy link
Collaborator

lengau commented Sep 25, 2023

I agree! We're migrating the full charmcraft.yaml description to pydantic models, after which we should be able to automatically generate the JSON schema. This will need some additional work in craft-parts as well, but that work would also be reusable

@lengau
Copy link
Collaborator

lengau commented Sep 25, 2023

Note to the implementer, this would include:

  1. Changes to automatically generate the schema in an appropriate place (possibly in CI, possibly on release?
  2. creating the schema and PRing a relevant change to the schema store. See: Add snapcraft to the catalog SchemaStore/schemastore#668

@lengau lengau added the Enhancement New feature or request label Apr 15, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CRAFT-2806.

This message was autogenerated

@lengau lengau added this to the 25.04 milestone Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request triaged
Projects
None yet
Development

No branches or pull requests

3 participants