Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use biolink Named Thing as root node #149

Open
wdduncan opened this issue Nov 9, 2021 · 2 comments
Open

Use biolink Named Thing as root node #149

wdduncan opened this issue Nov 9, 2021 · 2 comments

Comments

@wdduncan
Copy link

wdduncan commented Nov 9, 2021

The current root node is Entity. I think it would be advantageous to use Biolinks Named Thing as the root.

This allows for easier integration with Biolink and consistency across projects using LinkML (e.g., NMDC's Named Thing.

@bfurner
Copy link
Contributor

bfurner commented Nov 10, 2021

There appears to be some inconsistencies here. It looks like the Biolink model has 'Entity' as it's root element with 'NamedThing' as a child: https://biolink.github.io/biolink-model/docs/Entity.html. NMDC, on the other hand, does have a root entity of 'NamedThing'

@mbrush do you have thoughts on Entity vs NamedThing?

@wdduncan
Copy link
Author

@bfurner Ah yes ... you are right Biolink does have an entity class. I like the clean separation between named things and associations. This might benefit the ccdh model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants