Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more specific about specific kinds of observation types #133

Open
gaurav opened this issue Oct 12, 2021 · 1 comment
Open

Be more specific about specific kinds of observation types #133

gaurav opened this issue Oct 12, 2021 · 1 comment
Assignees
Labels
model Issues relating to the CRDC-H model

Comments

@gaurav
Copy link
Collaborator

gaurav commented Oct 12, 2021

In the CRDC Tech talk just now, Denise Warzel pointed out that there were different kinds of weights, and that we should be very specific of which kind of weight we mean here.

@gaurav gaurav changed the title Be more specific about types of observation types Be more specific about specific kinds of observation types Oct 12, 2021
@bfurner
Copy link
Contributor

bfurner commented Oct 18, 2021

Here is the example that raised the comment from Denise. Her suggestion was to use a more granular concept for this observation_type (e.g. current biospecimen weight - C181724) rather than the more generic concept of 'weight'.

quantity_measure:
  - observation_type:
      coding:                                                 # type = Coding 
        - code: C25208                                            
          label: Weight                                       
          system: http://ncithesaurus.nci.nih.gov             
          tag:                                               
            - harmonized                                      
    value_quantity:                                           # type = Quantity
      value_decimal: 45
      unit:
        coding:                                               # type = Coding 
          - code: C28253                                            
            label: Milligram                                     
            system: http://ncithesaurus.nci.nih.gov             
            tag:                                              
              - harmonized    

@gaurav gaurav added the model Issues relating to the CRDC-H model label Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
model Issues relating to the CRDC-H model
Projects
None yet
Development

No branches or pull requests

2 participants