Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the console output for followed Camel-k logs #39

Open
bfitzpat opened this issue Jul 9, 2019 · 6 comments
Open

Enhance the console output for followed Camel-k logs #39

bfitzpat opened this issue Jul 9, 2019 · 6 comments

Comments

@bfitzpat
Copy link
Contributor

bfitzpat commented Jul 9, 2019

Per apupier - "maybe in a next iteration but it seems that Kubernetes extension is providing a nice Log viewer as a view or an editor. it might be better than using the podOutputChannel (and still cannot test but it seems that in case of several pod, the log will be mixed in it, isn't it?)"

Me - So far as I know, we can't rely on elements from other extensions -- has that changed?

Aurelien - you're right. Then maybe in a next iteration, duplicate the log editor code (or find a way to extract it as a normal javascript extension and submit it)

Good thoughts here - we will have to see what we can do to improve it.

@bfitzpat
Copy link
Contributor Author

Looks like this is one of the issues - vscode-kubernetes-tools/vscode-kubernetes-tools#460

@bfitzpat
Copy link
Contributor Author

And perhaps this is the webview they've added - https://github.com/Azure/vscode-kubernetes-tools/blob/master/src/components/logs/logsWebview.ts

@bfitzpat
Copy link
Contributor Author

We cannot add color to the output channel apparently. (Tried using the Chalk https://www.npmjs.com/package/chalk library and it's just ignored.)

@apupier
Copy link
Member

apupier commented Aug 23, 2019

We cannot add color to the output channel apparently. (Tried using the Chalk https://www.npmjs.com/package/chalk library and it's just ignored.)

seems to be related to this feature request microsoft/vscode#571

@bfitzpat
Copy link
Contributor Author

Though we could go with an approach similar to what the Kubernetes extension is doing with webview, I would rather not open a separate window (essentially an editor) when we already have the output channels down below. It may be the only way to get "prettier" text for the logs, but it seems like a workaround more than anything else...

And I don't believe the Colorizer approach (https://code.visualstudio.com/api/extension-capabilities/theming) will work, since it applies to code syntax coloring in editors and views, not specifically the output channels.

@bfitzpat
Copy link
Contributor Author

bfitzpat commented Feb 10, 2020

Looks like spinning out the logs into separate windows like the Kubernetes extension may actually give us the functionality we are looking for. A new request for having more information more readily available (perhaps something like https://twitter.com/LostInTangent/status/1207718123241033728 or https://twitter.com/LostInTangent/status/1211342492324388864).

If we spin up these log windows as separate from the output view, we can move them around like we want. We can also look at finding a way to get easier access to the log for the Camel K operator.

image(3)

bfitzpat added a commit that referenced this issue Feb 19, 2020
* issue #39 - early work on updating the log display

* updating the log webview so it works
* adding sterr handling
* automatically scroll to the bottom of the log
* added auto-scroll checkbox to turn it on and off
* adding filter controls back in to fix bug with disappearing log entries upon move
* adding changelog messages
* correcting indention issues, updating the readme, and handling other PR feedback
* removing generated testFixture settings file from commit
* correcting indent on script code included in log view html

Signed-off-by: [email protected] <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants