Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix feedback pop up in about section when there is no internet #43

Open
KianBadie opened this issue Feb 16, 2022 · 2 comments
Open

Fix feedback pop up in about section when there is no internet #43

KianBadie opened this issue Feb 16, 2022 · 2 comments

Comments

@KianBadie
Copy link
Collaborator

KianBadie commented Feb 16, 2022

Feedback pop up is broken when opened without an internet connection (in the offline versions). Create a better looking fallback to substitute if the feedback pop up can not be displayed properly.

offline

@KianBadie
Copy link
Collaborator Author

@coiko In the past, we had a simple message to display if there was no internet. Since I deeply refactored a lot of the site components, that functionality no longer exists unfortunately. If it was ok with you, I wanted to save reimplementing this after the update so I can think of a proper way to do this instead of a quick fix. How do you feel about this? I have attached a screenshot of what the form looks like when there is no internet connection.

@coiko
Copy link
Collaborator

coiko commented Feb 17, 2022

@KianBadie Of course! That sounds like a good plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants