-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom scroll container #50
Comments
I see an old PR, #24, adding support for a custom scroll container. Would love to see that in the library :D |
I created a PR too, see #51 |
Any plans for this to land in one of the next versions? |
Yes please merge this PR :) |
Any chance of getting this merged in? Can we do something to help with this? |
Disappointed this hasn't been addressed. PR #24 doesn't appear to bloat the library which was the initial concern, and this feature is necessary for SPAs |
Yea, I had to switch to Velocity.js which is unfortunate as it comes with plenty of features I never use. |
Would be great to get this merged for @mikebywaters reasonings. I have a div that I want to scroll instead of window. |
Please merge this PR! |
1 similar comment
Please merge this PR! |
Any idea why this PR is not getting merged? Seems like a useful one! |
For what it's worth for anyone else coming across here, I personally decided to use Anime.js (only around 6KB). See an example of how to smooth scroll here: https://codepen.io/rukiadia/pen/qYyLdw As you can see a custom container element is quite easy to setup. Since this PR hasn't been merged or looked at for so long I worry that something has happened to the original creator. I hope he/she is doing okay but I would consider this library effectively deprecated from new changes. |
Thanks for writing jump.js, it has a nice API!
I have a use case where I would like to scroll not the window as a whole, but the contents of a specific div. It would be great if I could configure a custom container element rather than using
window
. As far as I can see that's currently not possible or am I overlooking something?The text was updated successfully, but these errors were encountered: