Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify reaction parameters interface #67

Open
schmoelder opened this issue May 3, 2021 · 0 comments · May be fixed by #77
Open

Simplify reaction parameters interface #67

schmoelder opened this issue May 3, 2021 · 0 comments · May be fixed by #77
Labels
good first issue Good starting point for newcomers, easy to fix

Comments

@schmoelder
Copy link
Contributor

Currently there is some ambiguity regarding the parameter fields of reactions.

Sometimes, the field reaction is used for the bulk parameters, sometimes reaction_bulk.

I suggest the following approach:

Always distinguish between reaction_model_bulk, and reaction_model_particle. When a unit has no particles, ignore reaction_model_particle. Consequently, for the parameters, always use reaction_bulk and reaction_particle respectively.

See also this discussion.
@schmoelder schmoelder added the good first issue Good starting point for newcomers, easy to fix label May 14, 2021
@schmoelder schmoelder linked a pull request May 18, 2021 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good starting point for newcomers, easy to fix
Projects
CADET-Project
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improved reactions interface cadet/CADET-Core
2 participants
@ronald-jaepel @schmoelder