Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PDF Support #8

Open
blizzardengle opened this issue Jun 11, 2021 · 2 comments
Open

Add PDF Support #8

blizzardengle opened this issue Jun 11, 2021 · 2 comments
Labels
feature request A new feature that seems possible to add help wanted Extra attention is needed

Comments

@blizzardengle
Copy link
Member

This is a beta feature already being developed. Once beta is stable it should be merged into JamsEDU for the 2.0 release.

UPDATE: This feature works now. Styles, especially margins, needs tweaking still.
@blizzardengle blizzardengle added the feature request A new feature that seems possible to add label Jun 11, 2021
@blizzardengle
Copy link
Member Author

UPDATE: This feature is effectively broken in production. There are race condition issues and to many unnecessary dependencies. I will need to look into building my own viewer from scratch and ditching the PDFJS viewer that is causing all the problems. This will be a massive amount of work.

@blizzardengle blizzardengle added the on hold Temporarily place this issue on hold until it fits the schedule or a matching release. label Jun 13, 2021
@blizzardengle
Copy link
Member Author

UPDATE: I got this working by creating my own viewer. Moving forward JamsEDU will use PDF.js Mini Viewers (PMV) which replaces the PDF.js viewer with one that works better with JamsEDU.

@blizzardengle blizzardengle added help wanted Extra attention is needed and removed on hold Temporarily place this issue on hold until it fits the schedule or a matching release. labels Jun 18, 2021
@blizzardengle blizzardengle pinned this issue Jun 18, 2021
@blizzardengle blizzardengle moved this to In progress in JamsEDU 2.0 Jun 29, 2023
@blizzardengle blizzardengle unpinned this issue Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request A new feature that seems possible to add help wanted Extra attention is needed
Projects
JamsEDU 2.0
Status: In progress
Milestone
No milestone
Development

No branches or pull requests
1 participant
@blizzardengle