Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeyError for TrustDirection and TrustType #57

Open
emilyastranova opened this issue Nov 11, 2024 · 2 comments · May be fixed by #58
Open

KeyError for TrustDirection and TrustType #57

emilyastranova opened this issue Nov 11, 2024 · 2 comments · May be fixed by #58

Comments

@emilyastranova
Copy link

It looks like something might have changed in a dependency where now instead of something like 1, the result is Inbound, so the lookup in the dict for TrustDirection and TrustType fails since those are values and not keys. Working on a PR right now to attempt lookup by value in the event this happens.
@emilyastranova emilyastranova linked a pull request Nov 11, 2024 that will close this issue
Open
@emilyastranova
Copy link
Author

PR open #58

@c3c
Copy link
Owner

c3c commented Nov 13, 2024

odd, thanks for reporting, i'll have an opportunity soon with multiple trusts to verify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed trust direction/type error emilyastranova/ADExplorerSnapshot.py
2 participants
@c3c @emilyastranova