Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC support for older CURL versions on production #228

Open
2 tasks done
StanJansen opened this issue Oct 7, 2022 · 0 comments
Open
2 tasks done

BC support for older CURL versions on production #228

StanJansen opened this issue Oct 7, 2022 · 0 comments

Comments

@StanJansen
Copy link

StanJansen commented Oct 7, 2022

The CURLOPT_PINNEDPUBLICKEY is not supported on older CURL versions but it's hardcoded to be used. Sadly cannot upgrade CURL on short-term in this case, but in all tags compatible with PHP8 this is the case.

Steps to reproduce:

  1. Install a CURL version < 7.39.0 (CURLOPT_PINNEDPUBLICKEY got added in 7.39.0: https://www.php.net/manual/en/function.curl-setopt.php).
  2. Use the API Client with production

What should happen:

  1. The CURLOPT_PINNEDPUBLICKEY set in https://github.com/bunq/sdk_php/blob/develop/src/Http/ApiClient.php#L320 should not be set if the option does not exist in the CURL version of the server.

What happens:

  1. An error is thrown because the option is unknown.

SDK version and environment

  • Tested on 1.20.22.26
  • Sandbox (option is not used on sandbox)
  • Production
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant