Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paging is not fully integrated. #428

Open
Exscotticus opened this issue Aug 23, 2024 · 2 comments
Open

Paging is not fully integrated. #428

Exscotticus opened this issue Aug 23, 2024 · 2 comments

Comments

@Exscotticus
Copy link

Basic paging (hit the button and get more results) does indeed work.

The problem is when you try to use it with pre-existing attrs.allNodes loops such as: clearHighlighting() and expandAll().

When using paging, these function should follow the paging rules in accordance with minPagingVisibleNodes and pagingStep. They should not process every single node. The entire point of paging is to prevent that.

@bumbeishvili
Copy link
Owner

bumbeishvili commented Aug 26, 2024

@Exscotticus clearHighlighting sets some props on all nodes, I am not sure if it would break any functionality

image

As for the expandAll, not exactly sure how it works currently, but I would assume that it will expand all nodes including the nodes that are hidden because of paging

image

Can you provide a specific example of what is happening and what you think should happen?

A Stackblitz sample would help

@Exscotticus
Copy link
Author

@bumbeishvili thanks for responding.

update(attrs.root) and updateNodesState() and render() are causing all the hidden nodes to be rendered as if there was no paging. So if the data consisted of a single root node with 5000 children but only a few showing because of paging—the UI thread freezes for many seconds as all 5000 children are rendered.

I'll see if I can create an example for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants