From b6587603a23ddd8acdf1229947566c01e9a76d24 Mon Sep 17 00:00:00 2001 From: Brandon Duffany Date: Wed, 9 Oct 2024 08:50:46 -0700 Subject: [PATCH] Add some extra logs when the executor returns MissingDigestError (#7696) --- enterprise/server/remote_execution/dirtools/dirtools.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/enterprise/server/remote_execution/dirtools/dirtools.go b/enterprise/server/remote_execution/dirtools/dirtools.go index 6776c979f5e..ef91a5a5c0e 100644 --- a/enterprise/server/remote_execution/dirtools/dirtools.go +++ b/enterprise/server/remote_execution/dirtools/dirtools.go @@ -643,6 +643,7 @@ func (ff *BatchFileFetcher) batchDownloadFiles(ctx context.Context, req *repb.Ba fileCache := ff.env.GetFileCache() for _, res := range responses { if res.Err != nil { + log.CtxInfof(ctx, "Failed to download %s: %s", digest.String(res.Digest), res.Err) return digest.MissingDigestError(res.Digest) } d := res.Digest @@ -1009,6 +1010,9 @@ func DownloadTree(ctx context.Context, env environment.Env, instanceName string, } childDir, ok := dirMap[digest.NewKey(child.GetDigest())] if !ok { + if child.GetDigest() == nil { + log.CtxInfof(ctx, "Directory child digest is nil (parentDir=%q, childName=%q)", parentDir, child.GetName()) + } return digest.MissingDigestError(child.GetDigest()) } if err := fetchDirFn(childDir, newRoot); err != nil {