Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues in the submitted 11.0.2 packages #12

Open
boris-kolpackov opened this issue Sep 13, 2024 · 0 comments
Open

Issues in the submitted 11.0.2 packages #12

boris-kolpackov opened this issue Sep 13, 2024 · 0 comments

Comments

@boris-kolpackov
Copy link

I haven't done a thorough review but noticed the following non-blocking issues:

  • Smoke test uses a different source file extension (.cxx) compared to upstream (.cc. Normally we want to use the same extension for consistency.

  • I see you've disabled a bunch of build configurations because of the bugs in upstream (that are even fixed in the next versions). Normally we only disable build configuration if they are explicitly declared as unsupported by upstream. The typical example would be MinGW GCC which many don't bother supporting.

  • I think the package-email field in the manifest needs to be updated to reflect the maintainer change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant