You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I haven't done a thorough review but noticed the following non-blocking issues:
Smoke test uses a different source file extension (.cxx) compared to upstream (.cc. Normally we want to use the same extension for consistency.
I see you've disabled a bunch of build configurations because of the bugs in upstream (that are even fixed in the next versions). Normally we only disable build configuration if they are explicitly declared as unsupported by upstream. The typical example would be MinGW GCC which many don't bother supporting.
I think the package-email field in the manifest needs to be updated to reflect the maintainer change.
The text was updated successfully, but these errors were encountered:
I haven't done a thorough review but noticed the following non-blocking issues:
Smoke test uses a different source file extension (
.cxx
) compared to upstream (.cc
. Normally we want to use the same extension for consistency.I see you've disabled a bunch of build configurations because of the bugs in upstream (that are even fixed in the next versions). Normally we only disable build configuration if they are explicitly declared as unsupported by upstream. The typical example would be MinGW GCC which many don't bother supporting.
I think the
package-email
field in the manifest needs to be updated to reflect the maintainer change.The text was updated successfully, but these errors were encountered: