Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative-navigated imports don't work in SolidityCompiler -- code fix #117

Open
3Nigma opened this issue Oct 18, 2022 · 0 comments
Open
Labels
contracts LiveContract/Smart contract related question Further information is requested
Milestone

Comments

@3Nigma
Copy link
Contributor

3Nigma commented Oct 18, 2022

#114 looked at having Contract.allFrom({ path }) variants working when doing .. imports. We need to have import resolution working for Contract.allFrom({ code }) as well.

This raises an interesting question: what is the base-path from which the .. import are resolved when passing in code to compile via SolidityCompiler into Contracts? We might need to add a basePath (or similar) prop to SolidityCompiler.compile to pass that in. If we're going down this path, we might need to bump the release version to 0.9.0 since the rollup-plugin-strato-js package will also need to be updated to a backward incompatible version.

@3Nigma 3Nigma added question Further information is requested contracts LiveContract/Smart contract related labels Oct 18, 2022
@3Nigma 3Nigma added this to the Back-burner milestone Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contracts LiveContract/Smart contract related question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant