Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

Improve modal dismiss experience #319

Open
rylek90 opened this issue Aug 7, 2021 · 0 comments
Open

Improve modal dismiss experience #319

rylek90 opened this issue Aug 7, 2021 · 0 comments

Comments

@rylek90
Copy link

rylek90 commented Aug 7, 2021

I've recently noticed that Modal component's experience might be improved a bit.

Without a closeButton prop modal can be dismissed with an escape button but only if it's pressed within its container. I think it should either: ignore button press at all without closeButton prop or handle it within whole document context. I can push PR with a fix but I need some guidance if it's a reasonable improvement in your opinion 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant