You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.
I've recently noticed that Modal component's experience might be improved a bit.
Without a closeButton prop modal can be dismissed with an escape button but only if it's pressed within its container. I think it should either: ignore button press at all without closeButton prop or handle it within whole document context. I can push PR with a fix but I need some guidance if it's a reasonable improvement in your opinion 😄
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I've recently noticed that
Modal
component's experience might be improved a bit.Without a
closeButton
prop modal can be dismissed with an escape button but only if it's pressed within its container. I think it should either: ignore button press at all withoutcloseButton
prop or handle it within whole document context. I can push PR with a fix but I need some guidance if it's a reasonable improvement in your opinion 😄The text was updated successfully, but these errors were encountered: