fix: ensure images are totally prcoessed before using them (ios) #478
Conversation
`img.decode = () => resolve(img);` is supposed to ensure that the image is fully processed but is misused. Decode is not a setter, it's a method that returns a promise when the image is fully decoded. While this code wait for the image to load it does not wait for it to be fully ready (processed). `img.decode()` ensures that the image has been fully decoded before continuing. We go one step further with `requestAnimationFrame`. This defers the execution and will ensure that the resolved image is rendered in the next frame. It's more important in devices like Ipad because the broswers tend to handle image operations differently, thus creating rendering and timing issues.
|
💖 Thanks for opening this pull request! 💖 Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #478 +/- ##
==========================================
+ Coverage 62.93% 63.10% +0.17%
==========================================
Files 10 10
Lines 580 580
Branches 143 143
==========================================
+ Hits 365 366 +1
Misses 151 151
+ Partials 64 63 -1 ☔ View full report in Codecov by Sentry. |
|
when will the version be updated? |
How should I do this? |
|
We have same issue here. Any news? Was the pull approved? |
|
Ran into this same issue today with Safari MacOS. Would love to see this pull approved if it fixes the issue! |
|
when is this fix going to be released? I'm getting the blanc images on safari |
|
I tried it. It doesn't useful. |
Description
img.decode = () => resolve(img);is supposed to ensure that the image is fully processed but is misused. Decode is not a setter, it's a method that returns a promise when the image is fully decoded. While this code wait for the image to load it does not wait for it to be fully ready (processed).img.decode()ensures that the image has been fully decoded before continuing.We go one step further with
requestAnimationFrame. This defers the execution and will ensure that the resolved image is rendered in the next frame. It's more important in devices like Ipad because the broswers tend to handle image operations differently, thus creating rendering and timing issues.Motivation and Context
Images were not rendered when printing documents which have images on ipad. But is is working fine outside IOS.
IOS has been know to have some rendering and timing issues.
Fixes #461
Types of changes
Self Check before Merge