Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

responsive-customizer-colors inline code not printing to "Default" theme #195

Open
ghost opened this issue Sep 14, 2018 · 5 comments
Open

Comments

@ghost
Copy link

ghost commented Sep 14, 2018

Responsive Version: 2.0

Expected behavior: responsive-customizer-colors inline-code should be attaching to in order for color theme to take affect

Actual behavior: responsive-customizer-colors inline-code missing

Link generated by whatsmybrowser.org:

Link(s) where this can be reproduced: whatsmybrowser.org/b/M9A75A5

Steps to reproduce:

  1. Put Responsi in "Default" color theme
  2. ex. Utility nav css not showing

Screenshot (if this is a bug):

screen shot 2018-09-14 at 10 33 40 am

Related ServiceNow Ticket number (if available):

@ashleykolodziej
Copy link
Contributor

Verified this is still an issue here: http://bun.cms-devl.bu.edu/responsi/

@ashleykolodziej
Copy link
Contributor

This is actually a Foundation bug, since Customizer doesn't output styles for the default palette. Moving.

@ashleykolodziej ashleykolodziej transferred this issue from bu-ist/responsive-framework Jan 8, 2019
@ghost ghost self-assigned this Jan 10, 2019
@ghost
Copy link
Author

ghost commented Jan 10, 2019

@ashleykolodziej so the reason I believe that it may be a framework issue is that when 'Default' is published, customizer doesn't actually load the responsive-customizer-colors.css into the header, which is why it isn't overriding. And its not just the utility-nav, i'm realizing it's all the color for that theme aren't loading, even thought they are mapped in customizer.php

@ashleykolodziej
Copy link
Contributor

Ohhhhhhhh

Interesting! I see what you mean.

I'm going to leave this here because we're about to rip the custom color pickers out, so those PHP variables aren't going to matter soon anyway, and we do need to fix this over here. But that's a solid catch, thank you!

@ghost
Copy link
Author

ghost commented Jan 10, 2019

@ashleykolodziej Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant