We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The importScriptAddress function of ScopedKeyManager takes a Lock on ScopedKeyManager, then a Lock on Manager.
importScriptAddress
ScopedKeyManager
Manager
The Address function of Manager takes a RLock on Manager, then a RLock/Lock on ScopedKeyManager.
Address
Combining the two can lead to a deadlock.
The text was updated successfully, but these errors were encountered:
There's other occasions too where the locks of manager and scoped manager are reversed. A decision must be made:
Probably manager first, then scoped manager makes most sense. ImportPublicKey and importScriptAddress have this issue
ImportPublicKey
Sorry, something went wrong.
We've been using this, apparently successfully, over the last few months: breez@04ba108
Let me know if I should PR that.
Looks like a worthy PR, sure. Thanks for investigating in the first place!
#942
yyforyongyu
No branches or pull requests
The
importScriptAddress
function ofScopedKeyManager
takes a Lock onScopedKeyManager
, then a Lock onManager
.The
Address
function ofManager
takes a RLock onManager
, then a RLock/Lock onScopedKeyManager
.Combining the two can lead to a deadlock.
The text was updated successfully, but these errors were encountered: