Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when write bucket failed, why return nil instead of err? #936

Open
czh0526 opened this issue Jul 3, 2024 · 1 comment
Open

when write bucket failed, why return nil instead of err? #936

czh0526 opened this issue Jul 3, 2024 · 1 comment

Comments

@czh0526
Copy link

czh0526 commented Jul 3, 2024

the error is in file waddrmgr/db.go at line 1216

func putAddrAccountIndex(...) error {
....

    // Write account keyed by address hash
err = bucket.Put(addrHash, uint32ToBytes(account))
if err != nil {
	return nil
}

     .....

}

@czh0526 czh0526 changed the title when return bucket failed, why return nil instead of err? when write bucket failed, why return nil instead of err? Jul 3, 2024
@yyforyongyu
Copy link
Collaborator

think it's a mistake we should fix🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants