Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli product version number behind tags #790

Open
chappjc opened this issue Feb 9, 2022 · 1 comment
Open

cli product version number behind tags #790

chappjc opened this issue Feb 9, 2022 · 1 comment

Comments

@chappjc
Copy link
Contributor

chappjc commented Feb 9, 2022

btcwallet/version.go

Lines 19 to 21 in 40518d7

appMajor uint = 0
appMinor uint = 11
appPatch uint = 0

Before next tag, would be ideal to bump the hard-coded version for the cli app. It's fairly inconsequential for go consumers, but it's nice when running btcwallet to have it reflect the general dev cycle that it was build from.

I had mentioned this before, but wanted to make an issue to track it. 😄

@Roasbeef
Copy link
Member

Good idea, we don't use the direct CLI much ourselves, but we should def start to update it properly each time we do a new tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants