Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change command getnewaddress #1703

Closed
medeirosfalante opened this issue Mar 26, 2021 · 2 comments · Fixed by #1776
Closed

change command getnewaddress #1703

medeirosfalante opened this issue Mar 26, 2021 · 2 comments · Fixed by #1776

Comments

@medeirosfalante
Copy link

in bitcoin core rpc api the method getnewaccount have a 2 params [label] [address_type] but in btcd/rpcclient have 1 param [account] this is corrent ?
@Roasbeef
Copy link
Member

Bitcoin Core changed their version, but the rpcclient still only accepts the args of the initial version. You can either craft a raw RPC request to pass in that new JSON, or make a PR to extend the rpcclient.

@chappjc
Copy link
Contributor

chappjc commented Dec 7, 2021 •
edited
Loading

Assuming this issue refers to getnewaddress, this would be resolved by #1776 plus btcsuite/btcwallet#783
Although there the "label" argument is still "account" in btcsuite's RPC, so I'm not sure how that will interact with Bitcoin Core.

@chappjc chappjc mentioned this issue Dec 7, 2021
Merged
@armandooj armandooj mentioned this issue Dec 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

btcjson: add addresstype arg to getnewaddress chappjc/btcd
3 participants
@Roasbeef @chappjc @medeirosfalante