last upgrade crashed on debian bookworm

[anarcat]

Our latest upgrade crashed because btcpayserver seems to think our docker install (20.10.24 in Debian bookworm) is too old. And the way it seems to handle this is ... rather sub par:

Subject: Cron <root@btcpayserver-02> /root/BTCPayServer/btcpayserver-docker/btcpay-update.sh

From https://github.com/btcpayserver/btcpayserver-docker
   6b5841e..4e8aa5e  master            -> origin/master
   e265d0d..aa55e7c  dcg-latest        -> origin/dcg-latest
 * [new branch]      joinmarket-0.9.10 -> origin/joinmarket-0.9.10
Updating 6b5841e..4e8aa5e
Fast-forward
 Production/nginx.tmpl                              |  19 +-
 README.md                                          |  23 +-
 btcpay-setup.sh                                    |  11 -
 btcpay-update.sh                                   |   5 +-
 contrib/DockerFileBuildHelper/Program.cs           |  27 ++-
 contrib/FastSync/README.md                         |   2 +-
 contrib/FastSync/load-utxo-set.sh                  |   2 +-
 contrib/FastSync/sigs/NicolasDorier.utxo-sets.asc  |  27 +--
 contrib/FastSync/utxo-sets                         |   3 +-
 contrib/build-all-images.sh                        | 238 ++++++++++-----------
 .../docker-fragments/bitcoin-lnd.yml               |   3 +-
 .../docker-fragments/bitcoin.yml                   |   2 +-
 .../docker-fragments/btcpayserver.yml              |   3 +-
 docker-compose-generator/docker-fragments/dash.yml |   2 +-
 .../docker-fragments/nbxplorer.yml                 |   4 +-
 .../docker-fragments/nginx-https.yml               |   6 +-
 .../docker-fragments/nginx.yml                     |   4 +-
 .../docker-fragments/opt-add-cloudflared.yml       |   2 +-
 .../docker-fragments/opt-add-fireflyiii.yml        |   1 +
 .../docker-fragments/opt-add-tallycoin-connect.yml |   1 +
 .../docker-fragments/opt-add-thunderhub.yml        |   3 +-
 .../docker-fragments/opt-add-tor-relay.yml         |   4 +-
 .../docker-fragments/opt-add-tor.yml               |   4 +-
 .../docker-fragments/opt-add-woocommerce.yml       |   1 +
 .../docker-fragments/postgres.yml                  |   2 +
 docker-compose-generator/linuxamd64.Dockerfile     |   4 +-
 docker-compose-generator/linuxarm32v7.Dockerfile   |   4 +-
 docker-compose-generator/linuxarm64v8.Dockerfile   |   4 +-
 .../src/docker-compose-generator.csproj            |   6 +-
 helpers.sh                                         |  59 +++--
 30 files changed, 247 insertions(+), 229 deletions(-)
Updating docker, old version can't run some images (https://docs.linuxserver.io/FAQ/#jammy)
E: The repository 'https://download.docker.com/linux/ubuntu bookworm Release' does not have a Release file.
Reading package lists...
Building dependency tree...
Reading state information...
Package docker-ce is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source

Package docker-ce-cli is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source

E: Package 'docker-ce' has no installation candidate
E: Package 'docker-ce-cli' has no installation candidate
E: Unable to locate package containerd.io
E: Couldn't find any package by glob 'containerd.io'
E: Couldn't find any package by regex 'containerd.io'

It would be nice if we could just leave our docker install alone, we're grown ups and can manage docker...

[anarcat]

I will also add that the FAQ refered in the output (https://docs.linuxserver.io/FAQ/#jammy) says the version should be 20.10.10, and we have 20.10.24, so we shouldn't need that upgrade in the first place.

In other words, the version check is just wrong, on top of the fix being wrong.