Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ConnectionResult enum #67

Open
konak opened this issue Apr 17, 2022 · 0 comments
Open

Change ConnectionResult enum #67

konak opened this issue Apr 17, 2022 · 0 comments

Comments

@konak
Copy link

konak commented Apr 17, 2022

Maybe it will be more correct to change ConnectionResult enum from:

public enum ConnectionResult
{
	Ok,
	CouldNotConnect
}

to

public enum ConnectionResult
{
	Unknown = 0,
	Ok = 1,
	CouldNotConnect = 2
}

In current implementation

connectionResult.HasFlag(ConnectionResult.Ok)

for CouldNotConnect will return true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant