Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

site_diff: Relative URLs with <base> tag not supported #127

Open
hlubek opened this issue Jan 22, 2015 · 1 comment
Open

site_diff: Relative URLs with <base> tag not supported #127

hlubek opened this issue Jan 22, 2015 · 1 comment

Comments

@hlubek
Copy link

hlubek commented Jan 22, 2015

Some websites use a <base href="http://www.example.com/" /> tag to specify the base for relative URLs. The site_diff script currently generates wrong URLs in these cases (the relative path is appended to the current URL of the page).

@hlubek hlubek changed the title Relative URLs with <base> tag not supported site_diff: Relative URLs with <base> tag not supported Jan 22, 2015
@bslatkin
Copy link
Owner

Good catch! That's a tricky one. What's your expectation of that behavior?

I figure the way it would have to work is to set the prefix here:

https://github.com/bslatkin/dpxdt/blob/master/dpxdt/tools/site_diff.py#L141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants