From 796b372058c2fcdb5dc16f92eb81b73daddc803b Mon Sep 17 00:00:00 2001 From: Bhumika Saini Date: Thu, 7 Sep 2023 17:45:05 +0530 Subject: [PATCH] [Remote Store] Update version check for Remote Translog Store upload flow stats in nodes stats API (#9754) Signed-off-by: Bhumika Saini Signed-off-by: Ivan Brusic --- .../java/org/opensearch/index/translog/TranslogStats.java | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/server/src/main/java/org/opensearch/index/translog/TranslogStats.java b/server/src/main/java/org/opensearch/index/translog/TranslogStats.java index 25bf40e129626..a4699cea671a0 100644 --- a/server/src/main/java/org/opensearch/index/translog/TranslogStats.java +++ b/server/src/main/java/org/opensearch/index/translog/TranslogStats.java @@ -71,9 +71,7 @@ public TranslogStats(StreamInput in) throws IOException { uncommittedOperations = in.readVInt(); uncommittedSizeInBytes = in.readVLong(); earliestLastModifiedAge = in.readVLong(); - // TODO: remoteTranslogStats = in.getVersion().onOrAfter(Version.V_2_10_0) ? in.readOptionalWriteable(RemoteTranslogStats::new) : - // new RemoteTranslogStats(); - remoteTranslogStats = in.getVersion().onOrAfter(Version.CURRENT) + remoteTranslogStats = in.getVersion().onOrAfter(Version.V_2_10_0) ? in.readOptionalWriteable(RemoteTranslogStats::new) : new RemoteTranslogStats(); } @@ -184,8 +182,7 @@ public void writeTo(StreamOutput out) throws IOException { out.writeVInt(uncommittedOperations); out.writeVLong(uncommittedSizeInBytes); out.writeVLong(earliestLastModifiedAge); - // TODO: if (out.getVersion().onOrAfter(Version.V_2_10_0)) { - if (out.getVersion().onOrAfter(Version.CURRENT)) { + if (out.getVersion().onOrAfter(Version.V_2_10_0)) { out.writeOptionalWriteable(remoteTranslogStats); } }