Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to make images conform in scale to fit line height of previous or next char #63

Open
subsoap opened this issue Aug 2, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@subsoap
Copy link
Contributor

subsoap commented Aug 2, 2020

Sometimes users may want to have emoticons in text and have them scale to be a part of a line to fit and not scale up the next line.

There should be options to scale up or not. That is if the image fits on the line without impacting the next line height, don't scale it down or up and leave it at is based scale.

If some text was made smaller, the image should get smaller with the line and scale to fit the text either before or after it if either don't exist.

@subsoap
Copy link
Contributor Author

subsoap commented Aug 2, 2020

Another option would be to have the image not scale but also not impact the line height in any way.

@britzl
Copy link
Owner

britzl commented Aug 12, 2020

Good suggestion!

@britzl britzl added the enhancement New feature or request label Aug 12, 2020
@britzl
Copy link
Owner

britzl commented May 4, 2022

What kind of syntax would be used for this?

-- url query format
<img=texture:image?scale=none&arg2=value2/>

-- comma separated
<img=texture:image,scale=none,arg2=value2/>

I'm leaning towards query format even though it is used differently here.

And what would the argument values be?

  • none = Do not adjust height of the image
  • fit = Scale image to fit height of text

There should probably also be an align property to say how the image aligns to the text vertically: "center", "bottom", "top"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants