Unhandled exception running the Code generator against a C# class with no namespace

[Numpsy]

I noticed this when trying to run the Dubrovnik.Generator.UI tool against a .NET library which exports a class that has no namespace defined.

The reflection part works ok, but then I get a NullReferenceException from http://www.github.com/ThesaurusSoftware/Dubrovnik/blob/master/dotNET/Dubrovnik.Tools/Dubrovnik.Tools/Net2ObjCPartial.cs#L1272 when doing the code gen step, as the 'managedIdentifier' parameter is a null string.

I'm not sure if the fix is just to return an empty string if managedIdentifier is null, or if it needs to handle that case differently.

[Thesaurus]

I would start by using an empty string in the null case and proceed from there.
There are some other locations in the code gen that might squeal if the namespace is null/nil but I reckon it will be pretty obvious.
One location might well be where we generate a macro contraction of a fully qualified classname :

#define TWGShortened This_Will_Get_Shortened

On 5 Jan 2016, at 18:12, Richard Webb [email protected] wrote:

I noticed this when trying to run the DubrovnikGeneratorUI tool against a NET library which exports a class that has no namespace defined

The reflection part works ok, but then I get a NullReferenceException from http://wwwgithubcom/ThesaurusSoftware/Dubrovnik/blob/master/dotNET/DubrovnikTools/DubrovnikTools/Net2ObjCPartialcs#L1272 when doing the code gen step, as the 'managedIdentifier' parameter is a null string

I'm not sure if the fix is just to return an empty string if managedIdentifier is null, or if it needs to handle that case differently

—
Reply to this email directly or view it on GitHub #4.

[Numpsy]

The next place it falls over is in Net2ObjC.tt

https://github.com/ThesaurusSoftware/Dubrovnik/blob/master/dotNET/Dubrovnik.Tools/Dubrovnik.Tools/Net2ObjC.tt#L394

I tried changing CodeFacet.TypeNamespace to be an empty string instead of a null string if there is no namespace present, and that allowed the generation to succeed.

[Thesaurus]

You will have to account for the fact that the namespace is currently suffixed with a period. An empty namespace won't require that,