Problem if number of observations exceeds number of chains x number of samples

[schwa021]

Hi Brian,

Thanks for the amazing code. MatlabStan has been absolutely wonderful to use.

I discovered (and solved) a very minor bug. I deal with fairly large data sets. If my number of observations exceeds number of chains x number of samples, then the fit.extract method fails.

I tracked down the issue, and it is an easy fix. in mcmc.m you set a size variable (sz) as:

           sz = size(temp);

you then use this in the subsequent line:

            temp = temp(self.permute_index(1:max(sz)),:);

But, when nobservations>nchains*nsamples, this crashes since max(sz) no longer applies to the proper index.

The trivially easy fix is to replace max(sz) with sz(1).

          temp = temp(self.permute_index(1:sz(1)),:);

Probably very few people run into this bug. However, if/when you release an update, it is an easy change to make.