-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upon error, check for new version and suggest to upgrade #49
Comments
Exceptions/errors could happen due to many different reasons (not just out-dated CLI), but the bottom line is that, user should never see "unhandled exception"; CLI should be updated with proper try/catch in various exception throwing sections of the code. I do think it's a good idea to always check for outdated CLI installation upon execution, and display warning messages. I think CLI can download the package.json from the master branch of this repo and see if it matches the version listed in package.json
By the way, if a user wants to ensure that they always use the latest version of CLI, they can add this to
singularity makes sure that it has the latest version of docker container cached locally and it will download the latest version if it's not up-to-date. See https://brainlife.io/docs/cli/install/#docker-container |
Handling the errors / catch-all would be very good, more user friendly |
Actually I shouldn't just look at master branch's package.json. I should somehow query the current version from npmjs
and compare it against the version in |
When an unhandled exception happen, check if the current installed version is the last one. The check should fail silently and timeout quick. Print out the upgrade command in case the version is older than what's published in npm.
The text was updated successfully, but these errors were encountered: