Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky tests in PopupMenuComponent #700

Open
smbea opened this issue Nov 18, 2022 · 1 comment
Open

Fix flaky tests in PopupMenuComponent #700

smbea opened this issue Nov 18, 2022 · 1 comment
Labels
backlog Queued in backlog spring cleaning Could be cleaned up one day

Comments

@smbea
Copy link
Contributor

smbea commented Nov 18, 2022

What should we do?

Some PopupMenuComponentSpec test are flaky (see here). This is due to the async rendering.

Currently, a setTimeout is being used but it's is still causing flakiness and we should not rely on this.

Why should we do it?

This affects our CI and is annoying.

@smbea smbea self-assigned this Nov 18, 2022
@smbea smbea added the ready Ready to be worked on label Nov 18, 2022
@smbea
Copy link
Contributor Author

smbea commented Nov 18, 2022

Some initial considerations to handle this:

  • use preact's utilityact like we use in properties panel
    • not exported by preact direcly, its export in preact/test-utils
    • we would have to include it in diagram-js-ui
  • implement something that relies on requestAnimationFrame like act: https://github.com/preactjs/preact/blob/master/test-utils/src/index.js#L27
  • fire popupMenu.closed, popupMenu.opened, etc and rely on popupMenu.on...

@smbea smbea added the backlog Queued in backlog label Nov 28, 2022 — with bpmn-io-tasks
@smbea smbea removed the ready Ready to be worked on label Nov 28, 2022
@smbea smbea removed their assignment Feb 21, 2023
@smbea smbea added the spring cleaning Could be cleaned up one day label Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog spring cleaning Could be cleaned up one day
Projects
None yet
Development

No branches or pull requests

1 participant