We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BaseRenderer
Describe the Bug
With minification active the following fails:
import inherits from 'inherits'; import BaseRenderer from 'diagram-js/lib/draw/BaseRenderer'; function MyRenderer(injector) { injector.invoke(BaseRenderer, this, { renderPriority: 9001 }); } MyRenderer.$inject = [ 'injector' ]; inherits(MyRenderer, BaseRenderer);
This is due to the fact that the BaseRenderer does not ship with minification info ($inject).
$inject
Steps to Reproduce
The obvious workaround is to use the existing constructor call pattern; that is prone to error though as the BaseRender constructor args may change.
Expected Behavior
injector.invoke
BaseRenderer.call(this, ...)
Environment
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Describe the Bug
With minification active the following fails:
This is due to the fact that the
BaseRenderer
does not ship with minification info ($inject
).Steps to Reproduce
BaseRenderer
in a future proof wayThe obvious workaround is to use the existing constructor call pattern; that is prone to error though as the BaseRender constructor args may change.
Expected Behavior
injector.invoke
) in a minifcation safe mannerBaseRenderer.call(this, ...)
) contiunes to workEnvironment
The text was updated successfully, but these errors were encountered: