Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installed this and now I can no longer use Wagtail admin #29

Open
serl opened this issue Jun 10, 2023 · 1 comment
Open

Installed this and now I can no longer use Wagtail admin #29

serl opened this issue Jun 10, 2023 · 1 comment

Comments

@serl
Copy link
Contributor

serl commented Jun 10, 2023

Seems like the devs at Wagtail are not using fastdev!

image image

While I'll check with them to fix the undefined tag, I'm sure that's not the only exception.
It would be great if we could exclude specific apps (or directly all external code), with a configuration or something.

TLDR: I think that fastdev should not run outside of the project's boundaries.

Longer explanation: while I totally agree on the fact that undefined variables must explode as they always do everywhere else, I feel that the Django templating language is meant to be more permissive. For me, that simply means that we could find ourselves adding apps to our projects which are written by people not sharing our same views on undefined variables, and are not willing to "fix" what is not a problem to them.

@boxed
Copy link
Owner

boxed commented Jun 12, 2023

Yea, maybe a simple whitelist that is regexes on template names will do. I'm open to a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants