Skip to content

Latest commit

 

History

History
59 lines (45 loc) · 2.54 KB

CONTRIBUTING.md

File metadata and controls

59 lines (45 loc) · 2.54 KB

Contribution guide

Welcome! We are glad that you want to contribute to our project! 💖

This project accepts contributions via Github pull requests.

This document outlines the process to help get your contribution accepted.

There are many ways to contribute:

You can start by looking through the good first issues.

Fork the repository

In general, we follow the "fork-and-pull" Git workflow.

Here's a quick guide:

  1. Create your own fork of the repository
  2. Clone the project to your machine
  3. To keep track of the original repository, add another remote named upstream
git remote add upstream [email protected]:bouvet/nord-juice-shop.git
  1. Create a branch locally with a succinct but descriptive name and prefixed with change type.
git checkout -b feature/my-new-feature
  1. Make the changes in the created branch.
  2. Add the changed files
git add path/to/filename
  1. Commit your changes using the conventional commits formatting for the commit messages.
git commit -m "conventional commit formatted message"
  1. Before you send the pull request, be sure to rebase onto the upstream source. This ensures your code is running on the latest available code.
git fetch upstream
git rebase upstream/main
  1. Push to your fork.
git push origin feature/my-new-feature
  1. Submit a pull request to the original repository (via the Github interface). Please provide us with some explanation of why you made the changes you made. For new features, make sure to explain a standard use case to us.

That's it... thank you for your contribution!

After your pull request is merged, you can safely delete your branch.

Code review process

The core team (defined in CODEOWNERS) looks at pull requests on a regular basis. After feedback has been given we expect responses within three weeks. After three weeks we may close the pull request if it isn't showing any activity.