Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #661 and #683 by only allowing html to be set inside jQuery object
This introduce a minor breaking change -
So naively using bootbox without sanitizing input should be relatively safe without the risk of XSS
I added a few tests to check this changes but since there were no existing tests to verify
the old functionality of html strings so I only added a few basic ones.
I know this is a breaking change and there was a bit of a push back against actually adding it in so I understand if you prefer to keep the old behavior as is.
If you do think this is simple enough to be included in I can probably add another pull request to update the docs