Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adding omit, prefix and suffix template parameters to all parsers #160

Open
tzlaine opened this issue Mar 8, 2024 · 0 comments
Open

Consider adding omit, prefix and suffix template parameters to all parsers #160

tzlaine opened this issue Mar 8, 2024 · 0 comments

Comments

@tzlaine
Copy link
Collaborator

tzlaine commented Mar 8, 2024

The new parameters would be something like:

bool Omit, typename Prefix, typename Suffix, ...

It turns out that the omit_parser::call() shows up pretty high in profiling of Parser. If each parser knew if it was wrapped in a notional omit[], omit[] could just take a parser, and return a copy with true for the template parameter Omit. This means that the actual function call to omit_parser::call() (and omit_parser itself) goes away.

No so sure the other two would be as big a win, but a lot of parsers are something like eps(cond) >> p (that's what if_(cond) expands to). If all those instances, and expect_parser itself, were just built in to every parser (with a nope when there's no prefix and/or sufffix condition(s)), that might similarly speed things up. expect_parser would just go away in that case.
tzlaine added a commit that referenced this issue Dec 9, 2024
@tzlaine
Add a new template, parser_modifiers, that will hold common modificat…
c647918 
…ions to

parsers, like turning off attribute generation (replacing omit_parser).
Change char_parser to support the use of parser_modifiers, and change lit() to
return a parameterized char_parser instead of char_parser wrapped in an
omit_parser.

See #160.
tzlaine added a commit that referenced this issue Dec 9, 2024
@tzlaine
Add a new template, parser_modifiers, that will hold common modificat…
e1c7225 
…ions to

parsers, like turning off attribute generation (replacing omit_parser).
Change char_parser to support the use of parser_modifiers, and change lit() to
return a parameterized char_parser instead of char_parser wrapped in an
omit_parser.

See #160.
tzlaine added a commit that referenced this issue Dec 9, 2024
@tzlaine
Add a new template, parser_modifiers, that will hold common modificat…
35a7bd3 
…ions to

parsers, like turning off attribute generation (replacing omit_parser).
Change char_parser to support the use of parser_modifiers, and change lit() to
return a parameterized char_parser instead of char_parser wrapped in an
omit_parser.

See #160.
tzlaine added a commit that referenced this issue Dec 9, 2024
@tzlaine
Change string_parser to support the use of parser_modifiers, and chan…
974154c 
…ge lit()

to return a parameterized string_parser instead of string_parser wrapped in an
omit_parser.

See #160.
tzlaine added a commit that referenced this issue Dec 14, 2024
@tzlaine
Apply the same sort of change as the previous two commits, but to all…
bc1b9d9 
… the

parsers not already modified.  Generalize with_parser_mods().  Remove
omit_parser, since it is now moot.

See #160.
tzlaine added a commit that referenced this issue Dec 14, 2024
@tzlaine
Apply the same sort of change as the previous two commits, but to all…
4487af0 
… the

parsers not already modified.  Generalize with_parser_mods().  Remove
omit_parser, since it is now moot.

See #160.
tzlaine added a commit that referenced this issue Dec 14, 2024
@tzlaine
Apply the same sort of change as the previous two commits, but to all…
702c509 
… the

parsers not already modified.  Generalize with_parser_mods().  Remove
omit_parser, since it is now moot.

See #160.
tzlaine added a commit that referenced this issue Dec 14, 2024
@tzlaine
Apply the same sort of change as the previous two commits, but to all…
5db8ce0 
… the

parsers not already modified.  Generalize with_parser_mods().  Remove
omit_parser, since it is now moot.

See #160.
tzlaine added a commit that referenced this issue Dec 15, 2024
@tzlaine
Generalize with_parser_mods(), so that some functions can be recursiv…
0e77aa8 
…e, and

others can be non-recursive.

See #160.
tzlaine added a commit that referenced this issue Dec 15, 2024
@tzlaine
Change the no_case[] directive to use the parser_modifiers struct, li…
4e7fed2 
…ke omit[]

does; remove no_case_parser.

See #160.
tzlaine added a commit that referenced this issue Dec 17, 2024
@tzlaine
Add pre_- and post_parser members to parser_modifiers; these are used as
e1c86e3 
look-ahead/-behind positive or negative assertions.

When combining parsers using op>> and op>, if either side is an expect_parser
and the other side has an open pre_-/post_parser slot, take the subparser out
of the expect_parser, and use it directly in the pre_-/post_parser slot.

See #160.
tzlaine added a commit that referenced this issue Dec 17, 2024
@tzlaine
Add a new template, parser_modifiers, that will hold common modificat…
28e9b61 
…ions to

parsers, like turning off attribute generation (replacing omit_parser).
Change char_parser to support the use of parser_modifiers, and change lit() to
return a parameterized char_parser instead of char_parser wrapped in an
omit_parser.

See #160.
tzlaine added a commit that referenced this issue Dec 17, 2024
@tzlaine
Change string_parser to support the use of parser_modifiers, and chan…
2fff00b 
…ge lit()

to return a parameterized string_parser instead of string_parser wrapped in an
omit_parser.

See #160.
tzlaine added a commit that referenced this issue Dec 17, 2024
@tzlaine
Apply the same sort of change as the previous two commits, but to all…
2f7e596 
… the

parsers not already modified.  Generalize with_parser_mods().  Remove
omit_parser, since it is now moot.

See #160.
tzlaine added a commit that referenced this issue Dec 17, 2024
@tzlaine
Generalize with_parser_mods(), so that some functions can be recursiv…
fcd257a 
…e, and

others can be non-recursive.

See #160.
tzlaine added a commit that referenced this issue Dec 17, 2024
@tzlaine
Change the no_case[] directive to use the parser_modifiers struct, li…
54f8eec 
…ke omit[]

does; remove no_case_parser.

See #160.
tzlaine added a commit that referenced this issue Dec 17, 2024
@tzlaine
Add pre_- and post_parser members to parser_modifiers; these are used as
88abb61 
look-ahead/-behind positive or negative assertions.

When combining parsers using op>> and op>, if either side is an expect_parser
and the other side has an open pre_-/post_parser slot, take the subparser out
of the expect_parser, and use it directly in the pre_-/post_parser slot.

See #160.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tzlaine