Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot be used on esp32 #3

Open
mikeleib opened this issue Nov 8, 2021 · 3 comments
Open

cannot be used on esp32 #3

mikeleib opened this issue Nov 8, 2021 · 3 comments

Comments

@mikeleib
Copy link

mikeleib commented Nov 8, 2021

Due to definition of OPEN_DRAIN at https://github.com/espressif/arduino-esp32/blob/master/cores/esp32/esp32-hal-gpio.h#L50, this library cannot be compiled on an esp32.

@flybrianfly
Copy link
Member

Can you bug the ESP32 Core Developers to scope this better? Using macros ignores scoping rules of the language and is causing this issue; if they had scoped it as a const or an enum, we wouldn't have a problem since OPEN_DRAIN is defined within the scope of the BMI088 class.

@svetgeorgiev
Copy link

What is the fix for this?

@flybrianfly
Copy link
Member

Either get the ESP32 devs to not use macros or rename OPEN_DRAIN in this library to something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants