Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HS Code info to InventoryItem #212

Closed
c9845 opened this issue May 18, 2023 · 2 comments
Closed

Add HS Code info to InventoryItem #212

c9845 opened this issue May 18, 2023 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@c9845
Copy link

c9845 commented May 18, 2023

The InventoryItem type is missing a number of fields to handle HS code information. Specifically, country_code_of_origin, country_harmonized_system_codes, harmonized_system_code, and province_code_of_origin.

Not sure if these were omitted for a specific reason or added to Shopify's API after this package was built out. Can these be added?

See https://shopify.dev/docs/api/admin-rest/2023-04/resources/inventoryitem#resource-object for the list of fields available for an InventoryItem.

@oliver006 oliver006 added help wanted Extra attention is needed good first issue Good for newcomers labels May 26, 2023
@oliver006
Copy link
Collaborator

Thanks for raising this. they were not omitted for a specific reason, probably cause they just got added later or the original author didn't need them.

This definitely could use some help, open a PR if you have a minute and I'll review and merge it asap.

@oliver006
Copy link
Collaborator

I think this got addressed by #213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants