Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Bobabeam, Bobabase support form gateway and cleanup files. #815

Closed
wants to merge 2 commits into from

Conversation

sk-enya
Copy link
Contributor

@sk-enya sk-enya commented May 14, 2023

📋 Add associated issues, tickets, docs URL here.

Overview

Remove boba beam/ boba base support from the Gateway and cleanup the code, as we are shutting down the boba beam.

Changes

Describe your changes and implementation choices. More details make PRs easier to review.

  • Remove boba beam, boba base feature gateway
  • Code cleanup

Testing

You won't be able to see the option to switch to Moonbeam / Moonbase network.

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.04 ⚠️

Comparison is base (5a19341) 51.78% compared to head (a62b307) 51.75%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #815      +/-   ##
===========================================
- Coverage    51.78%   51.75%   -0.04%     
===========================================
  Files          197      196       -1     
  Lines         7998     7988      -10     
  Branches      1651     1648       -3     
===========================================
- Hits          4142     4134       -8     
+ Misses        3856     3854       -2     
Flag Coverage Δ
coverage 51.75% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/boba/gateway/src/util/coinImage.ts 0.00% <ø> (ø)
packages/boba/gateway/src/util/constant.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sk-enya sk-enya force-pushed the fix/remove-bobabeam-code-cleanup branch from a62b307 to b920233 Compare May 15, 2023 15:38
@sk-enya sk-enya linked an issue May 24, 2023 that may be closed by this pull request
7 tasks
@sk-enya sk-enya marked this pull request as ready for review June 14, 2023 11:05
@sk-enya sk-enya changed the base branch from develop to release/v0.7.3 June 14, 2023 11:24
@sk-enya sk-enya changed the base branch from release/v0.7.3 to develop June 14, 2023 11:24
@sk-enya
Copy link
Contributor Author

sk-enya commented Jun 14, 2023

@sk-enya sk-enya closed this Jun 14, 2023
@sk-enya sk-enya deleted the fix/remove-bobabeam-code-cleanup branch June 16, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove BobaBeam (Moonbeam) and BobaOpera (Fantom) from repo - Checklist
2 participants