Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API for temporalDateLike, temporalDurationLike, etc. inputs #55

Open
nekevss opened this issue Jun 18, 2024 · 1 comment
Open
Labels
C-api Changes related to the public API C-tracking-issue Issues tracking a set of tasks that need to be done

Comments

@nekevss
Copy link
Member

nekevss commented Jun 18, 2024

Currently, parameters on some calls differ a tad from specification. Instead of supporting a "Like" item, we take specific values. Ideally, these should be updated to the below.

  • temporalDateLike to Into<Date>
  • temporalDurationLike to Into<Duration>
  • temporalTimeZoneLike to Into<TimeZone>
@nekevss nekevss added C-api Changes related to the public API C-tracking-issue Issues tracking a set of tasks that need to be done labels Jun 18, 2024
@jedel1043
Copy link
Member

From #84 (comment):

I think the spec API is fine, but in my opinion the APIs should be adapted to the explicitness of Rust APIs instead of having a 1-1 equivalent in both, which in this case means having some function that people can call to get the calendar before calling the function, instead of filling the API with generics.
This is partly because any APIs that have generics in them will make it really difficult to implement FFI interfaces for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-api Changes related to the public API C-tracking-issue Issues tracking a set of tasks that need to be done
Projects
None yet
Development

No branches or pull requests

2 participants