Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: merge with upstream v1.4.15 #54

Merged
merged 29 commits into from
Oct 18, 2024
Merged

feat: merge with upstream v1.4.15 #54

merged 29 commits into from
Oct 18, 2024

Conversation

irrun
Copy link
Collaborator

@irrun irrun commented Oct 18, 2024

Description

add a description of your changes here...

Rationale

tell us why we need these changes...

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

zzzckck and others added 29 commits August 26, 2024 16:09
apply `Eth.Miner.GasCeil` to TxPool even the node did not enable `--mine` option
Otherwise, there could be accmulated pending transactions in txpool.
Take an example:
- Currently, BSC testnet's block gaslimit is 70M, as 20M gas is reserved for
  SystemTxs, the maximum acceptable GasLimit for transaction is 50M.
- TxPool recevied a transaction with GasLimit 60M, it would be accepted in TxPool but it
  will never be accepted by validators. Such kinds of transactions will be kept in txpool
  and gradually make the txpool overflowed
Otherwise the node will be waiting for 500ms before the block fetcher
keeps processing.
This PR tries to improve bnb-chain#2680
If the node did not set `Eth.Miner` in config.toml, the default GasCeil
will be 30000000, it is not an accurate number for both BSC mainnet and testnet.
Set it to 0 means disable the transaction GasLimit check, i.e. the TxPool will
accept transactions with any GasLimit size.
others changes:
  - remove bsc-docker, as it is broken
  - remove light client, as it is no longer supported
…heck

eth/handler: remove duplicate check for lists in body
upload-artifact and download-artifact must use same version, otherwise
release workflow will fail.
https://github.com/actions/toolkit/blob/main/packages/artifact/docs/faq.md
@irrun irrun merged commit ceb1993 into develop Oct 18, 2024
4 of 6 checks passed
@irrun irrun deleted the merge-v1.4.15 branch October 18, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants