Thoughts on SocketAddr switchboard #3
Comments
|
I'd be happy to accept any contributions :) That would probably be a good change since it would make the type more interchangeable. I wish there was a set of standard socket traits for connecting/listening so that they would be completely interchangeable but such is the current state of things. The primary reason I implemented the address using a Though thinking about this more perhaps the |
|
Yeah, I figure the switchboard can have keys for every possible host/port combo, and therefore mimic "The entire internet" instead of just one port. It wouldn't make sense to listen on 0.0.0.0 in that case, but if we assume one ip per machine, I think it's reasonable to set up test nets with multiple addresses. I'll throw together a prototype tomorrow and see what issues come up. |
|
Sounds good! Look forward to seeing it :) |
|
It's not quite working yet, but before I forget: Kudos from a fellow Brandon Sanderson fan. ;-) |
The basic idea is the same, but it better mimics
the normal socket interface.
The Switchboard can now be thought of as
a parody of the entire internet
instead of a single machine.
Most everything is a direct mapping,
but there are two uncertain situations:
* When connect() is called, there is no clear indicator
as to where the client is connecting *from*.
So if we ever wanted to implement e.g. peer_addr
on a MemorySocket,
the behaviour would be undefined.
* It is not clear what address to listen on when
connecting to 0.0.0.0.
Both of these *could* be solved by mapping to the local
machine address (using e.g the get_if_addrs crate),
but I'm not sure that make sense.
Another option I toyed with was having a "set_connect_address"
global, but that simply lacked elegance.
( Discussion in bmwill#3 )
|
There it is. BTW, in a parallel project, I've been trying to make that set of dialer traits you mentioned, but only for async usage. I'll talk to my boss about open sourcing it since you mentioned it as being useful. They're a bit of a mess, I'm afraid; without generic abstract traits, Rust is, in my opinion, an unfinished language! |
|
If I'm not mistaken, this change was pushed on master but never released. Could you please publish a new version on Cargo so we can use it? |
For my use as a test socket, I'm looking for memory-socket to mimic a normal socket as much as possible.
In order to fully mimic them, I'd like the keys in the SWITCHBOARD to be SocketAddr instead of u16s. This would allow me to call it seamlessly with other socket traits. I know that'd be a huge breaking change for memory-socket, and I'm happy to maintain my own fork. But I wanted to run it by you in case a) you'd accept the contribution and b) you had a good reason not to implement it that way so I can avoid making such a mistake. ;-)
The text was updated successfully, but these errors were encountered: