Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle NL80211_CMD_SCAN_ABORTED command #3

Open
bmegli opened this issue Oct 13, 2016 · 2 comments
Open

Handle NL80211_CMD_SCAN_ABORTED command #3

bmegli opened this issue Oct 13, 2016 · 2 comments

Comments

@bmegli
Copy link
Owner

bmegli commented Oct 13, 2016

We should handle NL80211_CMD_SCAN_ABORTED command in notifications channel.

Otherwise we may have the following race condition:

  • we read up notifications
  • we trigger scan if necessary
  • we wait for completion
  • we collect results

It's possible that If the scan is aborted after triggering, before completion we may wait indefinitely for results. I am not sure, this needs investigation.

@bmegli bmegli self-assigned this Oct 13, 2016
@nini-os
Copy link

nini-os commented Jun 23, 2020

Any hints on how to implement this? It is very useful.

@bmegli
Copy link
Owner Author

bmegli commented Jun 23, 2020

Probably in handle_NL80211_MULTICAST_GROUP_SCAN, the case for NL80211_CMD_SCAN_ABORTED.

This is called from two places:

  • in non blocking readout of any pending notifications
  • while waiting for scan results

Some logic could be added to either:

  • (re)schedule scan
  • or report error

I am not sure it is needed. Ideally a way to abort scan and check what happens would be handy.

@bmegli bmegli removed their assignment Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants