Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we do EigerTriggerInfo via load/save instead? #727

Open
coretl opened this issue Jan 9, 2025 · 1 comment
Open

Can we do EigerTriggerInfo via load/save instead? #727

coretl opened this issue Jan 9, 2025 · 1 comment

Comments

@coretl
Copy link
Collaborator

coretl commented Jan 9, 2025

It is defined here to be the standard TriggerInfo, but with energy too, so that it can be done all in one go.

class EigerTriggerInfo(TriggerInfo):
energy_ev: float = Field(gt=0)

We should discuss with @DominicOram and @olliesilvester if we still need that approach after #697. This will depend on what exactly is slow in the Eiger.

@olliesilvester
Copy link
Contributor

Regarding what's slow in the eiger arming, MX are working on timings for each part of the chain: DiamondLightSource/dodal#1001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants