Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package the json schema files in release #326

Open
evalott100 opened this issue Oct 25, 2024 · 2 comments
Open

Package the json schema files in release #326

evalott100 opened this issue Oct 25, 2024 · 2 comments

Comments

@evalott100
Copy link
Contributor

After changing event_model/schema to src/event_model/schema, blueapi's json schema aquiring broke:

https://github.com/DiamondLightSource/blueapi/blob/44b9f12352d9a6967fb6bd812bbe9e258802344b/docs/reference/asyncapi.yaml#L97

I think we should set up the jsonschema files as attributes on releases like we do with ioc-pmac:

https://github.com/epics-containers/ioc-pmac/releases
@evalott100 evalott100 changed the title Host the json schema files some other way Package the json schema files in release Oct 25, 2024
@coretl
Copy link
Contributor

coretl commented Oct 29, 2024

Maybe not required after DiamondLightSource/blueapi#684 (comment)

@evalott100
Copy link
Contributor Author

evalott100 commented Oct 29, 2024 •
edited
Loading

Maybe not required after

Probably not, but would still be nice I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@evalott100 @coretl