Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libarb is has been rolled into libflint-arb. CMakeFileList.txt needs to be updated. #311

Open
Tafnab opened this issue Feb 9, 2024 · 3 comments · May be fixed by #317
Open

libarb is has been rolled into libflint-arb. CMakeFileList.txt needs to be updated. #311

Tafnab opened this issue Feb 9, 2024 · 3 comments · May be fixed by #317

Comments

@Tafnab
Copy link

Tafnab commented Feb 9, 2024

I was just building your lib when I found out libarb has been merged into Flint. Debian 12 supplies libflint-arb2 and libflint-arb-dev packages. They install arb.h and the rest of the old arb.

I couldn't figure out your cmake setup to change that. It would depend on the version of flint >2.x. The new arb files seem to be installed pretty much where you would expect, however the cmake bombs when I try to build WITH_ARB.

Thanks.

@bluescarni
Copy link
Owner

Hi @Tafnab!

Yes it is a bit of a tricky situation. I am a bit unsure on how to proceed, given that for at least a while older versions of flint/arb (as separate packages) will still be around and will have to be supported. The fact that even in the new flint versions they are still using autotools on Unix instead of CMake does not help (with CMake it would be much easier to detect the version of flint for instance).

If you want to take a crack at updating mp++'s build system for the new flint, a PR would be much appreciated.

@Tafnab
Copy link
Author

Tafnab commented Feb 12, 2024

The reason I mentioned the new pacakge names is that, if they are present, it must be the new arb. It will hopefully be easy to fix cmake by first testing for the new package and, if not present, failing over to the old.

However, I really don't like cmake. Every time I have to fix some cmake build, it's with a manual and stackoverflow helping me. I'll eventually take a crack at it, but I'm currently fixing other packages. Your CMakeLists.txt works very well with ccmake, but it looks complicated.

@7ofNine
Copy link
Contributor

7ofNine commented Feb 12, 2024

I think an additional issue could be that flintlib has dropped mpir support with version 3.1.0. Which creates the fun of trying to compile gmp on windows. For 64 bits that might be an interesting challenge. I don't know if using cygwin for compilation would be enough. I.e. starting to use flintlib in connection with mppp on windows, which is so far no great problem, would practically kill mppp usage.

chen1088 added a commit to chen1088/mppp that referenced this issue Nov 1, 2024
…to be updated.

Fixes bluescarni#311
A quick workaround so that we can compile with flint/arb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants